Add DCP compatibility for FSDP2-TP sharding in TransformerEngine.#2713
Draft
cspades wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Add DCP compatibility for FSDP2-TP sharding in TransformerEngine.#2713cspades wants to merge 2 commits intoNVIDIA:mainfrom
cspades wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Cory Ye <cye@nvidia.com>
for more information, see https://pre-commit.ci
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DTensorparameters with FP8, across allTransformerEngineBaseModule(s).Details
"shard"was the presumed weight sharding sub-mesh in theDTensor.device_mesh. Now, users can precisely specify their own custom weight-shardingDeviceMeshfor per-tensoramax_reduction_groupvia theset_device_meshAPI.Type of change
Changes
Please list the changes introduced in this PR:
Checklist: